Skip to content

feat: update entity and namedentity blueprints #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

pbullhove
Copy link
Contributor

@pbullhove pbullhove commented Nov 7, 2023

What does this pull request change?

NamedEntity extends Entity
NamedEntity only has required name

Updated tests to reflect new changes.

Why is this pull request needed?

Issues related to this change:

#687

@pbullhove pbullhove marked this pull request as ready for review November 7, 2023 11:21
@pbullhove pbullhove requested a review from a team as a code owner November 7, 2023 11:21
Copy link
Contributor

@soofstad soofstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing it took more than 5min, but LGTM! 😄

@pbullhove pbullhove force-pushed the feat/namedentity-entity-switch branch from a632e03 to 6a9b073 Compare November 13, 2023 09:08
@pbullhove pbullhove requested a review from soofstad November 14, 2023 07:56
@pbullhove pbullhove merged commit acb81ae into master Nov 14, 2023
@pbullhove pbullhove deleted the feat/namedentity-entity-switch branch November 14, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants