Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): Node.node_id() return invalid address to list elements #691

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix(node): Node.node_id() return invalid address to list elements #691

merged 1 commit into from
Nov 7, 2023

Conversation

soofstad
Copy link
Contributor

@soofstad soofstad commented Nov 7, 2023 •
edited
Loading

What does this pull request change?

  • Have Node.node_id() return a valid address for items in a list

Why is this pull request needed?

When using add_document(), I expect to be able to use the returned address to fetch the newly created entity.

Issues related to this change:

blocking "recurring job handler"

@soofstad soofstad self-assigned this Nov 7, 2023
@soofstad soofstad requested a review from a team as a code owner November 7, 2023 13:54
eoaksnes
eoaksnes approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@eoaksnes eoaksnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

@soofstad soofstad merged commit 4897834 into master Nov 7, 2023
3 checks passed
@soofstad soofstad deleted the fix/node_id_on_list_elements branch November 7, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eoaksnes eoaksnes eoaksnes approved these changes

Assignees

@soofstad soofstad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soofstad @eoaksnes