Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/create entity use default on optional #694

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

soofstad
Copy link
Contributor

NOTE: Depends on #693

What does this pull request change?

Fixes a bug in CreateEntity where optional attributes were not instantiated when provided default values.

Why is this pull request needed?

Was not behaving as intended

Issues related to this change:

closes #684

@soofstad soofstad requested a review from a team as a code owner November 10, 2023 11:18
@soofstad soofstad self-assigned this Nov 10, 2023
@soofstad soofstad force-pushed the fix/create-entity-use-default-on-optional branch from 7c5732f to a3adfe9 Compare November 14, 2023 08:31
@soofstad soofstad force-pushed the fix/create-entity-use-default-on-optional branch from a3adfe9 to c3b3037 Compare November 14, 2023 08:45
@soofstad soofstad enabled auto-merge (rebase) November 14, 2023 10:41
Copy link
Contributor

@collinlokken collinlokken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@soofstad soofstad merged commit 2b0dbe0 into master Nov 16, 2023
3 checks passed
@soofstad soofstad deleted the fix/create-entity-use-default-on-optional branch November 16, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: create_entity of type blueprint should insert default attributes
2 participants