Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: address_resolver did not use new datasource name #697

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix: address_resolver did not use new datasource name #697

merged 1 commit into from
Nov 14, 2023

Conversation

soofstad
Copy link
Contributor

@soofstad soofstad commented Nov 14, 2023 •
edited
Loading

What does this pull request change?

  • Fix a bug in address_resolver where it did not use the new data_source when resolving a reference to another data_source
  • Add test that catches this case

Why is this pull request needed?

bug

Issues related to this change:

none

@soofstad soofstad self-assigned this Nov 14, 2023
@soofstad soofstad requested a review from a team as a code owner November 14, 2023 08:30
collinlokken
collinlokken approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@collinlokken collinlokken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@soofstad soofstad merged commit 55d2051 into master Nov 14, 2023
3 checks passed
@soofstad soofstad deleted the fix/resolve-address-diff-datasource branch November 14, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@collinlokken collinlokken collinlokken approved these changes

Assignees

@soofstad soofstad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soofstad @collinlokken