Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/header plugin test- just a draft of the docs to see if it works. #1408

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

pbullhove
Copy link
Contributor

@pbullhove pbullhove commented Mar 19, 2024

What does this pull request change?

Just adding some draft docs.
This must be published for the tsDocs to find it and publish it in the docosaurus.

Why is this pull request needed?

Issues related to this change

@pbullhove pbullhove marked this pull request as ready for review March 19, 2024 13:55
@pbullhove pbullhove requested a review from a team as a code owner March 19, 2024 13:55
Copy link
Contributor

@awesthouse awesthouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍🏻

  1. If there are cases where we want to use more than one image, maybe we should have a static or image folder to put them in - just to get some structure
  2. Should use jpeg for images to reduce file size

@pbullhove pbullhove merged commit 7416783 into main Mar 19, 2024
8 checks passed
@pbullhove pbullhove deleted the docs/header-plugin-test branch March 19, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants