refactor: merge functionality for results #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsolaas
force-pushed
the
ECALC-136-refactor-time-series-table-data-frame-functionality-in-core-results
branch
from
24cf571 to
222f93f
Compare
TeeeJay
reviewed
Sep 21, 2023
| class TabularTimeSeries(Protocol): | ||
| timesteps: List[datetime] | ||
|
|
||
| def copy(self) -> Self: |
TeeeJay
reviewed
Sep 21, 2023
| return merged_object | ||
|
|
||
| @classmethod | ||
| def merge(cls, *tabular_time_series_list: TabularTimeSeries): |
TeeeJay
reviewed
Sep 21, 2023
| """ | ||
|
|
||
| @classmethod | ||
| def _merge_helper(cls, *objects_with_timeseries: ObjectWithTimeSeries) -> ObjectWithTimeSeries: |
TeeeJay
approved these changes
Sep 21, 2023
jsolaas
force-pushed
the
ECALC-136-refactor-time-series-table-data-frame-functionality-in-core-results
branch
3 times, most recently
from
a1e7740 to
c22c718
Compare
Make the merge functionality easier to reuse and extend.
jsolaas
force-pushed
the
ECALC-136-refactor-time-series-table-data-frame-functionality-in-core-results
branch
from
c22c718 to
da6ae59
Compare
jsolaas
deleted the
ECALC-136-refactor-time-series-table-data-frame-functionality-in-core-results
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the merge functionality easier to reuse and extend.