fix: don't raise error when missing time series on token collection #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsolaas
commented
Dec 10, 2024
There was a problem hiding this comment.
Weird diff. I moved init logic to create, with an additional raise_on_error flag.
TeeeJay
approved these changes
Dec 10, 2024
jsolaas
force-pushed
the
fix/validation-errors-missing-time-series-file
branch
from
4801ca0 to
d4d40a5
Compare
jsolaas
commented
Dec 10, 2024
| resources=self.resources, | ||
| raise_on_error=True, | ||
| ) | ||
| assert len(err) == 0 |
There was a problem hiding this comment.
raise_on_error should make this empty
When collecting the tokens from time series collection, we don't want to raise an error since that would limit the information we get from validation. Instead we want to collect the tokens we can, then validate the model based on that context. The errors will still give information about a missing resource, but also additional information, and file context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When collecting the tokens from time series collection, we don't want to
raise an error since that would limit the information we get from
validation. Instead we want to collect the tokens we can, then validate
the model based on that context. The errors will still give information
about a missing resource, but also additional information, and file
context.