Skip to content

Commit

Permalink
Merge branch 'bose/2272' into staging
Browse files Browse the repository at this point in the history
  • Loading branch information
BorghildSelle committed Apr 30, 2024
2 parents 9c9e7e2 + 426afa9 commit 93a769d
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 8 deletions.
14 changes: 12 additions & 2 deletions web/pageComponents/pageTemplates/TopicPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import Seo from '../shared/Seo'
import { SharedBanner } from './shared/SharedBanner'
import { PageContent } from './shared/SharedPageContent'
import SharedTitle from './shared/SharedTitle'
import { Breadcrumbs } from '@core/Breadcrumbs'
import { Breadcrumbs } from '../topicPages/Breadcrumbs'

const TopicPageLayout = styled.main`
/* The neverending spacing story... If two sections with the same background colour
Expand Down Expand Up @@ -56,9 +56,19 @@ const TopicPage = ({ data }: TopicPageProps) => {
<Breadcrumbs
background={titleStyles.background}
slug={data?.slug}
breadcrumbs={breadcrumbs?.defaultBreadcrumbs}
useCustomBreadcrumbs={breadcrumbs?.useCustomBreadcrumbs}
defaultBreadcrumbs={breadcrumbs?.defaultBreadcrumbs}
customBreadcrumbs={breadcrumbs?.customBreadcrumbs}
containerStyles={{
hasTopMargin: data.hero.type !== 'default',
}}
/>
/* <Breadcrumbs
background={titleStyles.background}
slug={data?.slug}
breadcrumbs={breadcrumbs?.defaultBreadcrumbs}
customBreadcrumbs={breadcrumbs?.customBreadcrumbs}
/> */
)}

{data.hero.type !== HeroTypes.DEFAULT && !data?.isCampaign && (
Expand Down
3 changes: 1 addition & 2 deletions web/pageComponents/topicPages/Breadcrumbs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ const StyledBreadcrumbsListItem = styled(BreadcrumbsListItem)<{ $bgColor?: Backg
`

const StyledNextLink = styled(NextLink)<{ $bgColor?: BackgroundColours }>`
text-decoration: none;
color: var(--color-on-background);
`

Expand Down Expand Up @@ -94,7 +93,7 @@ export const Breadcrumbs = ({
}
return (
<BreadcrumbsListItem key={item.slug}>
<StyledNextLink href={item.slug} prefetch={false}>
<StyledNextLink href={item.slug} prefetch={false} className="hover:underline no-underline">
{item.label}
</StyledNextLink>
</BreadcrumbsListItem>
Expand Down
8 changes: 4 additions & 4 deletions web/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 93a769d

Please sign in to comment.