Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 add workflow file for all studios and web #2672 #2673

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

millianapia
Copy link
Contributor

No description provided.

@millianapia millianapia requested a review from a team as a code owner November 12, 2024 15:04
@millianapia millianapia self-assigned this Nov 12, 2024
Copy link
Collaborator

@VarunVAshrit VarunVAshrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@padms padms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy studios job deploys only secret studio
Missing deploys to global and other satellite sites.

Deploy all webs only deploys global web.. satellite site deploy missing.

@padms
Copy link
Contributor

padms commented Dec 20, 2024

Deploy to backup cluster can be removed as we no longer use it.

id: get-token
uses: ./.github/workflows/get-auth-token/

- name: Deploy to Radix backup 🚀
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy to backup can be removed. There is a clean up task to remove app from backup cluster

status: ${{ job.status }}
steps: ${{ toJson(steps) }}
if: failure()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy Studios for satellites sites missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants