Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering on magazine tags on the /no/magasin page goes to Norwegian … #2727

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+1 −3
Open

Filtering on magazine tags on the /no/magasin page goes to Norwegian … #2727

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c7e3217
Filtering on magazine tags on the /no/magasin page goes to Norwegian …
VarunVAshrit Dec 17, 2024
27daac5
Removed commented code
VarunVAshrit Dec 17, 2024
0d1ee53
Revert "Removed commented code"
VarunVAshrit Dec 18, 2024
4aa4878
Revert "Filtering on magazine tags on the /no/magasin page goes to No…
VarunVAshrit Dec 18, 2024
da175eb
Merge branch 'main' into vaash/2687
VarunVAshrit Dec 18, 2024
daf3464
Merge branch 'main' into vaash/2687
VarunVAshrit Dec 20, 2024
27f2846
:bug:Filtering on magazine tags on the /no/magasin page
VarunVAshrit Dec 20, 2024
e11fd18
:bug: Changed parentSlug
VarunVAshrit Dec 20, 2024
44be986
Merge branch 'main' into vaash/2687
VarunVAshrit Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions web/templates/magazine/Magazineroom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ const MagazineRoom = ({ pageData, slug }: MagazineIndexTemplateProps) => {
const resultsRef = useRef<HTMLDivElement>(null)
const [isLoading, setIsLoading] = useState(false)
const router = useRouter()
const parentSlug =
(router.locale !== router.defaultLocale ? `/${router.locale}` : '') +
router.asPath.substring(router.asPath.indexOf('/'), router.asPath.lastIndexOf('/'))
const parentSlug = `${router.locale !== router.defaultLocale ? `/${router.locale}` : ''}${router.pathname}`

const magazineList = useMemo(() => magazineArticles, [magazineArticles])
const pagedList = useMemo(() => chunkArray(magazineList, 12), [magazineList])
Expand Down
Loading