Skip to content

Commit

Permalink
Disregard expected_objectives from OptimalResults
Browse files Browse the repository at this point in the history
The calculation within seba does not make sense,
and we do not use it for anything.
  • Loading branch information
yngve-sk committed Nov 13, 2024
1 parent 7369c4f commit 9339e8b
Show file tree
Hide file tree
Showing 8 changed files with 7 additions and 31 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -381,9 +381,6 @@
"point_x-1": 0.00635029,
"point_x-2": 0.38836369
},
"total_objective": -1.52561897,
"expected_objectives": {
"distance": -1.52561897
}
"total_objective": -1.52561897
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,6 @@
"point_y": 0.21233962,
"point_z": 0.49289096
},
"total_objective": -0.159768,
"expected_objectives": {
"distance": -0.159768
}
"total_objective": -0.159768
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,6 @@
"point_y": 0.49610079,
"point_z": 0.50412446
},
"total_objective": -0.00003229,
"expected_objectives": {
"distance": 0.0
}
"total_objective": -0.00003229
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,6 @@
"point_x": 3.0,
"point_y": 7.0
},
"total_objective": 7.0,
"expected_objectives": {
"func": 7.0
}
"total_objective": 7.0
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,6 @@
"point_y": 0.50022835,
"point_z": 0.49962361
},
"total_objective": -2.2e-7,
"expected_objectives": {
"distance": -2.2e-7
}
"total_objective": -2.2e-7
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,6 @@
"point_y": -0.00564829,
"point_z": 0.49992811
},
"total_objective": -2.00004834,
"expected_objectives": {
"distance_p": -0.50778502,
"distance_q": -4.47678995
}
"total_objective": -2.00004834
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,6 @@
"point_y": 0.50220467,
"point_z": 0.48265145
},
"total_objective": -0.00022499,
"expected_objectives": {
"distance": 0.0,
"stddev": 0.0
}
"total_objective": -0.00022499
}
}
1 change: 0 additions & 1 deletion tests/everest/test_api_snapshots.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ def test_api_snapshots(
"batch": optimal_result.batch,
"controls": optimal_result.controls,
"total_objective": optimal_result.total_objective,
"expected_objectives": optimal_result.expected_objectives,
}

api = EverestDataAPI(config)
Expand Down

0 comments on commit 9339e8b

Please sign in to comment.