Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests related to data_to_json #6146

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Sep 22, 2023

closes #6145
closes #6135

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@eivindjahren eivindjahren added the release-notes:skip If there should be no mention of this in release notes label Sep 22, 2023
@eivindjahren eivindjahren self-assigned this Sep 22, 2023
@eivindjahren eivindjahren merged commit 1017487 into main Sep 22, 2023
38 of 39 checks passed
@eivindjahren eivindjahren deleted the fix_flaky_data_to_json_test branch September 22, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
2 participants