Move everserver config to ServerConfig #9170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frode-aarstad
force-pushed
the
refactor-everserver-config
branch
2 times, most recently
from
9052a8b
to
907dc4f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9170 +/- ##
=======================================
Coverage 90.74% 90.75%
=======================================
Files 352 352
Lines 21937 21937
=======================================
+ Hits 19907 19909 +2
+ Misses 2030 2028 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
DanSava
approved these changes
Nov 12, 2024
src/everest/config/everest_config.py
Outdated
| @@ -605,7 +598,8 @@ def config_file(self) -> Optional[str]: | |||
| return None | |||
|
|
|||
| @property | |||
| def output_dir(self) -> Optional[str]: | |||
| # def output_dir(self) -> Optional[str]: | |||
Comment on lines
419
to
420
|
|
||
| # cert_folder = config.certificate_dir |
frode-aarstad
force-pushed
the
refactor-everserver-config
branch
from
907dc4f
to
246b854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9113
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable