Refactor usage of EverestConfig in everest server functionality #9181
+270
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9181 +/- ##
==========================================
- Coverage 90.78% 90.75% -0.03%
==========================================
Files 352 352
Lines 21935 21935
==========================================
- Hits 19913 19908 -5
- Misses 2022 2027 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
DanSava
force-pushed
the
everest-server-refactor-usafe-of-everest-config
branch
8 times, most recently
from
24340b4
to
09c0e89
Compare
DanSava
force-pushed
the
everest-server-refactor-usafe-of-everest-config
branch
from
09c0e89
to
ab2c26b
Compare
| file_path=os.path.join(log_dir, "simulations.log"), | ||
| log_level=logging.INFO, | ||
| ) | ||
|
|
There was a problem hiding this comment.
Are these logs now in everserver? or is everest_server.log removed
| @@ -225,24 +193,16 @@ def server_is_running(url: str, cert: bool, auth: Tuple[str, str]): | |||
| return True | |||
|
|
|||
|
|
|||
| def get_optimization_status(config: EverestConfig): | |||
There was a problem hiding this comment.
Was this function not used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9182
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable