Give warning if runpath disk space is close to full on ert startup #9193
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9193 +/- ##
==========================================
+ Coverage 90.77% 90.79% +0.02%
==========================================
Files 352 352
Lines 21935 21958 +23
==========================================
+ Hits 19911 19937 +26
+ Misses 2024 2021 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
larsevj
force-pushed
the
warn_on_full_disk
branch
from
8ed82e0
to
e51449b
Compare
larsevj
force-pushed
the
warn_on_full_disk
branch
from
e51449b
to
678f04d
Compare
|
initial attempt. Very open for suggestions regarding the text. |
|
Second alternative: |
larsevj
force-pushed
the
warn_on_full_disk
branch
from
4e76a62
to
da3bd16
Compare
src/ert/config/model_config.py
Outdated
| @@ -37,6 +48,9 @@ def str_to_datetime(date_str: str) -> datetime: | |||
| DEFAULT_JOBNAME_FORMAT = "<CONFIG_FILE>-<IENS>" | |||
| DEFAULT_ECLBASE_FORMAT = "ECLBASE<IENS>" | |||
|
|
|||
| FULL_DISK_PERCENTAGE_THRESHOLD = 0.97 | |||
| MINIMUM_BYTES_LEFT_ON_DISK = 200 * 1024**3 # 200 GB required | |||
There was a problem hiding this comment.
Hmm, we will get some complaints from all the Raspberry Pi users out there with a 16Gb memory card.
There was a problem hiding this comment.
Could we in some way leave this number for ert-configurations to set?
There was a problem hiding this comment.
The 0.97 is easier to accept as a general rule in Erts open source code.
There was a problem hiding this comment.
As discussed the 200 GB should only matter if you are using more than 97 % of your disk, and guards against the case were you have a very large disks.
There was a problem hiding this comment.
Should there be a comment in the source code on this?
|
Should this check be on startup or on experiment start? |
Might be better to be on experiment startup, seems like a lot of users ignore warnings on startup. Maybe we also should check space left on enspath? |
Yes, we should check there also, we have seen a lot of errors from missing capacity in enspath. Also, for enspath we could estimate how much space is necessary, but I suggest we keep that for another PR. |
Issue
Resolves #8921
The following is presented if disk is "close" to full:
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable