Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where Everest would not start with relative paths #9209

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Nov 13, 2024

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide force-pushed the fix_abs_path branch 2 times, most recently from 2e37e55 to 669d8bd Compare November 14, 2024 09:09
@oyvindeide oyvindeide marked this pull request as ready for review November 14, 2024 09:18
@oyvindeide oyvindeide added the release-notes:skip If there should be no mention of this in release notes label Nov 14, 2024
@oyvindeide oyvindeide self-assigned this Nov 14, 2024
@oyvindeide oyvindeide changed the title Fix bug where abs path could not be logged Fix bug where Everest would not start with relative paths Nov 14, 2024
@oyvindeide oyvindeide merged commit 79aad48 into equinor:main Nov 14, 2024
42 checks passed
@oyvindeide oyvindeide deleted the fix_abs_path branch November 14, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants