Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix faulty validation for maintained forward model objectives. #9225

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Nov 15, 2024

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@DanSava DanSava self-assigned this Nov 15, 2024
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.80%. Comparing base (eff341e) to head (a51afc7).

Additional details and impacted files
@@               Coverage Diff                @@
##           version-11.1    #9225      +/-   ##
================================================
- Coverage         90.85%   90.80%   -0.06%     
================================================
  Files               352      352              
  Lines             21959    21959              
================================================
- Hits              19951    19940      -11     
- Misses             2008     2019      +11     
Flag Coverage Δ
cli-tests 39.20% <ø> (-0.02%) ⬇️
gui-tests 71.81% <ø> (-0.01%) ⬇️
performance-tests 49.33% <ø> (-0.04%) ⬇️
unit-tests 79.63% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanSava DanSava merged commit cfe5ec4 into equinor:version-11.1 Nov 15, 2024
56 checks passed
@DanSava DanSava deleted the backport-fix-everest-objective-validation branch November 15, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants