-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use target and pose directly from Echo request #1057
Conversation
🔔 Changes in database folder detected 🔔 |
022f370
to
b102193
Compare
🔔 Migrations changes detected 🔔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
backend/api/Migrations/20231013121440_AddInspectionTargetToInspection.cs
Outdated
Show resolved
Hide resolved
541d487
to
686eae7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and seems to work well. Should be good to merge after fixing the formatting complaints.
bbfae76
to
0a4b8b6
Compare
b7e560a
to
92ea494
Compare
ae2e119
to
0c89241
Compare
d443c7b
to
6f4d60c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/UpdateDatabase |
👀 Running migration command... 👀 |
❌ Migration failed, please see action log below for details ❌ |
6f4d60c
to
c939b59
Compare
/UpdateDatabase |
👀 Running migration command... 👀 |
❌ Migration failed, please see action log below for details ❌ |
c939b59
to
ec48d41
Compare
/UpdateDatabase |
👀 Running migration command... 👀 |
✨ Successfully ran migration command! ✨ |
Note that the call to STID and the
InspectionTarget
inMissionTask
has not been removed yet. It was decided to do that in another PR to avoid too many breaking changes in one.