Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use target and pose directly from Echo request #1057

Merged
merged 9 commits into from
Nov 14, 2023

Conversation

aeshub
Copy link
Contributor

@aeshub aeshub commented Oct 13, 2023

Note that the call to STID and the InspectionTarget in MissionTask has not been removed yet. It was decided to do that in another PR to avoid too many breaking changes in one.

@aeshub aeshub added the improvement Improvement to existing functionality label Oct 13, 2023
@aeshub aeshub self-assigned this Oct 13, 2023
@github-actions
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@aeshub aeshub force-pushed the use-coordinates-from-echo branch 3 times, most recently from 022f370 to b102193 Compare October 13, 2023 12:16
@github-actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Oct 13, 2023
@aeshub aeshub changed the title Use inspection target directly from Echo request Use target and pose directly from Echo request Oct 13, 2023
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

backend/api/Controllers/Models/EchoInspection.cs Outdated Show resolved Hide resolved
backend/api/Controllers/Models/EchoInspection.cs Outdated Show resolved Hide resolved
backend/api/Services/Models/EchoPoseResponse.cs Outdated Show resolved Hide resolved
@aeshub aeshub force-pushed the use-coordinates-from-echo branch 2 times, most recently from 541d487 to 686eae7 Compare October 13, 2023 13:20
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and seems to work well. Should be good to merge after fixing the formatting complaints.

@aeshub aeshub force-pushed the use-coordinates-from-echo branch from bbfae76 to 0a4b8b6 Compare October 18, 2023 09:09
@aeshub aeshub force-pushed the use-coordinates-from-echo branch 3 times, most recently from b7e560a to 92ea494 Compare October 31, 2023 11:06
@aeshub aeshub force-pushed the use-coordinates-from-echo branch 7 times, most recently from ae2e119 to 0c89241 Compare November 14, 2023 12:55
@aeshub aeshub force-pushed the use-coordinates-from-echo branch 4 times, most recently from d443c7b to 6f4d60c Compare November 14, 2023 13:40
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeshub
Copy link
Contributor Author

aeshub commented Nov 14, 2023

/UpdateDatabase

Copy link

👀 Running migration command... 👀

Copy link

❌ Migration failed, please see action log below for details ❌
https://github.com/equinor/flotilla/actions/runs/6864527611

@aeshub aeshub force-pushed the use-coordinates-from-echo branch from 6f4d60c to c939b59 Compare November 14, 2023 14:02
@aeshub
Copy link
Contributor Author

aeshub commented Nov 14, 2023

/UpdateDatabase

Copy link

👀 Running migration command... 👀

Copy link

❌ Migration failed, please see action log below for details ❌
https://github.com/equinor/flotilla/actions/runs/6864706616

@aeshub aeshub force-pushed the use-coordinates-from-echo branch from c939b59 to ec48d41 Compare November 14, 2023 14:20
@aeshub
Copy link
Contributor Author

aeshub commented Nov 14, 2023

/UpdateDatabase

Copy link

👀 Running migration command... 👀

Copy link

✨ Successfully ran migration command! ✨

@aeshub aeshub merged commit 58461d3 into equinor:main Nov 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database-change Will require migration improvement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants