DEP: Deprecate content as dict input, split in two arguments #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnatt
force-pushed
the
deprecate_content_as_dict
branch
2 times, most recently
from
ff392e6 to
046460e
Compare
jcrivenaes
reviewed
Feb 20, 2025
jcrivenaes
approved these changes
Feb 20, 2025
mferrera
approved these changes
Feb 20, 2025
Comment on lines
+530
to
+531
| def _get_content_enum(self) -> Optional[enums.Content]: | ||
| """Get the content enum.""" |
There was a problem hiding this comment.
Not relevant to your PR, but this is the sort of thing that, IMO, should be done as part the initializer after #914, and internal state just has the enum value
There was a problem hiding this comment.
agree! there is a lot of here that can be taken away once we are done with the deprecation period 🎉 and also the issue you mention will be a step in the right direction! The code will be so much leaner, can't wait!
tnatt
force-pushed
the
deprecate_content_as_dict
branch
from
046460e to
78af9df
Compare
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to start deprecating
contentas a dictionary, and introduce a newcontent_metadataargument for the additional information.Closes #1012
Closes #1005