ENH: Calculate hashes in memory #846
Merged
+298
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnatt
force-pushed
the
hashes_in_memory
branch
from
9979d3a
to
ae52683
Compare
tnatt
force-pushed
the
hashes_in_memory
branch
6 times, most recently
from
95c2cb8
to
d206c09
Compare
tnatt
force-pushed
the
hashes_in_memory
branch
from
d206c09
to
97626b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that adds relevant functionality and changes from calculating MD5 hashes from file stream to memory stream when populating the
checksum_md5field if possible.For objects that do not support writing to memory streams they will still be written to temporary file before computing MD5, for dataio supported datatypes this applies to the
xtgeo.CubeonSEGYformat.Improves performance by dropping the need for doing a temporary export the object to disk in order to get the MD5 sum.
Closes #552