Fix reporting task/step status #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andchiind
force-pushed
the
invalid-joints-exception
branch
from
5bc879e to
18f6e22
Compare
andchiind
force-pushed
the
invalid-joints-exception
branch
from
c9cfdf5 to
ab7f990
Compare
andchiind
changed the title
andchiind
force-pushed
the
invalid-joints-exception
branch
from
ab7f990 to
dc21497
Compare
tsundvoll
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code is able to handle robots which report task status and not step status, but it was not suited to handle more fine grained reporting. I admit that the PR code is quite messy though and in need of some refactoring.