Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blocked protective stop state #694

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Add blocked protective stop state #694

merged 3 commits into from
Jan 15, 2025

Conversation

oysand
Copy link
Contributor

@oysand oysand commented Jan 15, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like logging, TODO, etc.
  • The PR has been tested locally
  • A test has been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that requires new issues
  • The changes do not introduce dead code as unused imports, functions etc.

@oysand oysand force-pushed the add-blocked-protective-stop-state branch from 1bddc7e to 71143d6 Compare January 15, 2025 05:53
@oysand oysand force-pushed the add-blocked-protective-stop-state branch from 71143d6 to b19d9b0 Compare January 15, 2025 08:17
@oysand
Ensure status checked before starting mission
ec5a803 
When entering Idle ISAR accept a new mission if
it is started. However, based on the robot status
it might be necessary to transition to a different
state rather than starting the mission.
@oysand oysand force-pushed the add-blocked-protective-stop-state branch from e375fef to ec5a803 Compare January 15, 2025 08:57
Christdej
Christdej approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oysand oysand merged commit 90099e2 into equinor:main Jan 15, 2025
7 checks passed
@oysand oysand deleted the add-blocked-protective-stop-state branch January 15, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christdej Christdej Christdej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oysand @Christdej