Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook with linear regression (Gauss-Linear model) #171

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

tommyod
Copy link
Collaborator

@tommyod tommyod commented Nov 16, 2023

  • Added the Gauss-Linear case in a notebook.
  • I believe this is a nice notebook to experiment with, since the Gauss-Linear case is what ESMDA is based on.
  • The notebook allows the user to easy experiment with (1) number of ensemble members, (2) number of parameters, (3) number of observations and (4) strength of the prior.

image

@tommyod tommyod marked this pull request as ready for review November 16, 2023 07:03
Copy link
Contributor

@Blunde1 Blunde1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through the notebook, and it looks brilliant. Great job 🚀
I had one small wish, but I can write that in an issue for later:

  • if we sample from a prior more aligned with the linear model, we should expect better posterior results than the uninformed maximum likelihood, right?

Anyway, probably good to just get this in ASAP without adding anything.

@tommyod
Copy link
Collaborator Author

tommyod commented Nov 16, 2023

if we sample from a prior more aligned with the linear model, we should expect better posterior results than the uninformed maximum likelihood, right?

Yes. For instance, if we sample a tight prior around what we know to be true values, we should beat the ML estimate.

Anyway, probably good to just get this in ASAP without adding anything.

Agree. I'll merge now. Feel free to do a pass through it after it's merged and update if you wish to.

@tommyod tommyod merged commit 6599b27 into equinor:main Nov 16, 2023
9 checks passed
@tommyod tommyod deleted the linear-regression branch November 16, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants