Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: eclipse cleanup #1127

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 37.14%. Comparing base (1b873a9) to head (744cb0e).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...cessEquipment/distillation/DistillationColumn.java 95.00% 1 Missing ⚠️
...c/main/java/neqsim/thermo/system/SystemThermo.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1127   +/-   ##
=========================================
  Coverage     37.14%   37.14%           
+ Complexity     5687     5685    -2     
=========================================
  Files           713      713           
  Lines         70789    70760   -29     
  Branches       8122     8117    -5     
=========================================
- Hits          26292    26283    -9     
+ Misses        42877    42860   -17     
+ Partials       1620     1617    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup. Can eclipse also change pacakenames to only lowercase letters?

@EvenSol EvenSol merged commit af48a7d into equinor:master Oct 5, 2024
6 checks passed
@EvenSol EvenSol added this to the v3.0.0 milestone Oct 6, 2024
@asmfstatoil asmfstatoil deleted the eclipse_cleanup branch October 6, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants