Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multi stream HX #1230

Merged
merged 4 commits into from
Jan 4, 2025
Merged

add multi stream HX #1230

merged 4 commits into from
Jan 4, 2025

Conversation

EvenSol
Copy link
Collaborator

@EvenSol EvenSol commented Jan 3, 2025

The current implementation needs more work, but solves the case where a dominating hot feed stream is coold be two or more streams. See test;
src/test/java/neqsim/process/equipment/heatexchanger/MultiStreamHeatExchangerTest.java

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 45.66929% with 138 lines in your changes missing coverage. Please review.

Project coverage is 40.98%. Comparing base (c78f834) to head (36bfcb5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ipment/heatexchanger/MultiStreamHeatExchanger.java 45.66% 131 Missing and 7 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1230      +/-   ##
============================================
+ Coverage     40.96%   40.98%   +0.01%     
- Complexity     5970     5988      +18     
============================================
  Files           718      719       +1     
  Lines         68019    68273     +254     
  Branches       8133     8163      +30     
============================================
+ Hits          27867    27983     +116     
- Misses        38473    38604     +131     
- Partials       1679     1686       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvenSol EvenSol merged commit 6cd2f4c into master Jan 4, 2025
10 checks passed
@EvenSol EvenSol deleted the add-multistream-HX branch January 4, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants