Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify UA for multi stream HX #1231

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Conversation

EvenSol
Copy link
Collaborator

@EvenSol EvenSol commented Jan 4, 2025

makes it possible to specify overall UA value of a multi stream HX. Method is not optimized for seed and ropbustnes, but works for test case.

src/test/java/neqsim/process/equipment/heatexchanger/MultiStreamHeatExchangerTest.java

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 80.43478% with 9 lines in your changes missing coverage. Please review.

Project coverage is 41.01%. Comparing base (6cd2f4c) to head (1c198a4).

Files with missing lines Patch % Lines
...ipment/heatexchanger/MultiStreamHeatExchanger.java 80.43% 3 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1231      +/-   ##
============================================
+ Coverage     40.98%   41.01%   +0.03%     
- Complexity     5988     5995       +7     
============================================
  Files           719      719              
  Lines         68273    68319      +46     
  Branches       8163     8171       +8     
============================================
+ Hits          27983    28024      +41     
+ Misses        38604    38603       -1     
- Partials       1686     1692       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvenSol EvenSol merged commit 3ece80c into master Jan 4, 2025
11 checks passed
@EvenSol EvenSol deleted the specify-UA-for-Multi-stream-HX branch January 4, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants