Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressor calculations with Leachman and Vega equation of state #1299

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

victorigi99
Copy link
Contributor

Added the possibility to do compressor calculations with Leachman and Vega

Added para and ortho-hydrogen as components and edited leachman accordingly

@victorigi99 victorigi99 requested a review from EvenSol as a code owner March 6, 2025 14:22
Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work👍

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 56.65138% with 189 lines in your changes missing coverage. Please review.

Project coverage is 42.14%. Comparing base (ac8fe05) to head (02163c2).

Files with missing lines Patch % Lines
...eqsim/process/equipment/compressor/Compressor.java 34.48% 59 Missing and 36 partials ⚠️
...rmodynamicoperations/flashops/PHflashLeachman.java 66.66% 12 Missing and 10 partials ⚠️
.../thermodynamicoperations/flashops/PHflashVega.java 66.66% 12 Missing and 10 partials ⚠️
src/main/java/neqsim/thermo/phase/Phase.java 37.50% 16 Missing and 4 partials ⚠️
...rmodynamicoperations/flashops/PSFlashLeachman.java 78.84% 6 Missing and 5 partials ⚠️
.../thermodynamicoperations/flashops/PSFlashVega.java 78.84% 6 Missing and 5 partials ⚠️
...va/neqsim/thermo/util/leachman/NeqSimLeachman.java 27.27% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1299      +/-   ##
============================================
+ Coverage     41.91%   42.14%   +0.22%     
- Complexity     6219     6319     +100     
============================================
  Files           733      737       +4     
  Lines         69805    70232     +427     
  Branches       8359     8448      +89     
============================================
+ Hits          29261    29601     +340     
- Misses        38757    38772      +15     
- Partials       1787     1859      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EvenSol EvenSol merged commit ea36568 into equinor:master Mar 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants