Skip to content

refactor: update jobs to run on latest os version #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

kov117
Copy link
Contributor

@kov117 kov117 commented Dec 10, 2024

BEGIN_COMMIT_OVERRIDE
feat: update jobs to run on latest OS version (#611)
END_COMMIT_OVERRIDE

@kov117 kov117 self-assigned this Dec 10, 2024
@kov117 kov117 requested a review from a team as a code owner December 10, 2024 09:17
@kov117 kov117 linked an issue Dec 10, 2024 that may be closed by this pull request
@kov117
Copy link
Contributor Author

kov117 commented Dec 10, 2024

I'm a little concerned about the terraform workflow, according to this overview , "Removed from the Ubuntu 24.04 image due to maintenance reasons." But the last edit on the post was on November the 5th. @hknutsen do you know perhaps if the terraform workflow works with the new OS version ? if its been tested and works then we keep it as it is, but if not then i will change the OS version on the workflow for terraform.

@hknutsen
Copy link
Member

@kov117 The Terraform workflow uses the hashicorp/setup-terraform action to install Terraform instead of relying of the version that used to be pre-installed on GitHub runners, so we should be fine, but feel free to test before getting an approval.

@hknutsen
Copy link
Member

Merged changes from main branch, which contains fixes for linter errors you were having in this branch 🕺

@kov117
Copy link
Contributor Author

kov117 commented Dec 13, 2024

@equinor/ops-actions-maintainers test was succesfull, it was as @hknutsen said, everything turned out fine. So review away 👍🏼

@hknutsen hknutsen merged commit 8b1544e into main Dec 13, 2024
12 checks passed
@hknutsen hknutsen deleted the 610-update-jobs-to-run-on-latest-os-version branch December 13, 2024 07:28
hknutsen added a commit that referenced this pull request Feb 25, 2025
Co-authored-by: Henrik Simonsen Knutsen <46495473+hknutsen@users.noreply.github.com>
hknutsen added a commit that referenced this pull request Feb 25, 2025
Co-authored-by: Henrik Simonsen Knutsen <46495473+hknutsen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update jobs to run on latest OS version
2 participants