Skip to content

Conversation

@SindreMohr
Copy link

@SindreMohr SindreMohr commented Dec 11, 2023

Description

Adds chip component to OPT-UI. Currently using internal components for storybook and close icon in the button, which needs to be replaced when icons are ready.

The Story type does not support hooks, so there is a warning on opt-ui-core/stories/dataDisplay/chip/Chip.stories.tsx L:28

Screenshots (if applicable)

Default

image

hover:
image

Selected

image

hover:
image

Default dark theme

image

hover:
image

Selected dark theme

image

hover:
image

Type of change

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to break)
  • Documentation update required for this change

Checklist:

  • My code adheres to the style guidelines of this project
  • I have performed a self-review of my code
  • I have added comments to my code, especially in complex areas
  • I have updated the documentation accordingly
  • My changes do not introduce any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my feature
  • Both new and existing unit tests pass locally with my changes
  • I have considered and addressed any potential security implications

@SindreMohr SindreMohr requested a review from spcttre December 11, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants