Skip to content

Conversation

@Strepto
Copy link
Collaborator

@Strepto Strepto commented Nov 7, 2025

What have I made? πŸ‘©β€πŸ’»

Adds a parameter to disable priority sectors, as priority sectors trip up the automated loading in reveal examples.

How can you best review this? 🧐

Read the code, check if a better name for the parameter could be good?

Did I remember everything checklist?

  • I made some awesome changes! 😎
  • I left the code in a better state than when I started working on it ✨
  • I wrote unit and/or integration tests πŸ‘Ύ
  • I have considered any security implications, and requested review of them explicitly πŸ”
  • I verified that it checks the acceptance criteria. πŸ“œ
  • I have tested this change in the Echo DEV environment, or requested someone to test it for me πŸš€
  • I updated the documentation/readme πŸ“š
  • I made the PR title descriptive and human-readable πŸ‘¨β€πŸ‘©β€πŸ‘¦β€πŸ‘¦
  • Existing unreported issues I found but could not fix was added as a new Issues 🚧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants