Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable PPCWMAX related test #611

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Re-enable PPCWMAX related test #611

merged 1 commit into from
Feb 27, 2024

Conversation

alifbe
Copy link
Collaborator

@alifbe alifbe commented Sep 29, 2023

Resolve #560

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.83969% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 86.46%. Comparing base (de57617) to head (c0c8db7).
Report is 35 commits behind head on main.

❗ Current head c0c8db7 differs from pull request most recent head 3755c5b. Consider uploading reports for the commit 3755c5b to get more accurate results

Files Patch % Lines
src/subscript/sector2fluxnum/flux_obj.py 41.66% 7 Missing ⚠️
src/subscript/sector2fluxnum/sector2fluxnum.py 61.53% 5 Missing ⚠️
...c/subscript/merge_unrst_files/merge_unrst_files.py 93.33% 3 Missing ⚠️
src/subscript/presentvalue/presentvalue.py 62.50% 3 Missing ⚠️
src/subscript/casegen_upcars/casegen_upcars.py 90.00% 2 Missing ⚠️
src/subscript/pack_sim/pack_sim.py 80.00% 2 Missing ⚠️
src/subscript/sector2fluxnum/flux_util.py 80.00% 2 Missing ⚠️
src/subscript/summaryplot/summaryplot.py 85.71% 2 Missing ⚠️
src/subscript/sunsch/sunsch.py 96.72% 2 Missing ⚠️
src/subscript/sunsch/time_vector.py 90.00% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
+ Coverage   84.72%   86.46%   +1.74%     
==========================================
  Files          52       50       -2     
  Lines        7507     6991     -516     
==========================================
- Hits         6360     6045     -315     
+ Misses       1147      946     -201     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alifbe alifbe requested review from mferrera and rnyb February 26, 2024 21:10
Copy link
Collaborator

@rnyb rnyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alifbe alifbe merged commit e09d265 into equinor:main Feb 27, 2024
6 checks passed
@alifbe alifbe deleted the re-enable_ppcwmax branch February 27, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable PPCWMAX related test
3 participants