Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge RFT data on report_step in addition to well and order #619

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Merge RFT data on report_step in addition to well and order #619

merged 2 commits into from
Oct 21, 2023

Conversation

alifbe
Copy link
Collaborator

@alifbe alifbe commented Oct 12, 2023

For observation with multiple report steps, it is necessary to also merge on report_step

Resolve #455

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Merging #619 (5d0ed91) into main (469a6ec) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 5d0ed91 differs from pull request most recent head ae6495d. Consider uploading reports for the commit ae6495d to get more accurate results

@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
+ Coverage   84.72%   84.74%   +0.01%     
==========================================
  Files          52       52              
  Lines        7510     7517       +7     
==========================================
+ Hits         6363     6370       +7     
  Misses       1147     1147              
Files Coverage Δ
src/subscript/merge_rft_ertobs/merge_rft_ertobs.py 95.06% <100.00%> (+0.46%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alifbe alifbe requested review from rnyb and tnatt October 12, 2023 11:36
Copy link
Collaborator

@rnyb rnyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alifbe alifbe merged commit 51175f1 into equinor:main Oct 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[merge_rft_ertobs] bug when more than one report step in obsdir
3 participants