Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmuobs Warning when using ERROR_MODE != ABS #628

Merged
merged 2 commits into from
Oct 27, 2023
Merged

fmuobs Warning when using ERROR_MODE != ABS #628

merged 2 commits into from
Oct 27, 2023

Conversation

alifbe
Copy link
Collaborator

@alifbe alifbe commented Oct 27, 2023

ERT observation config is re-using ERROR keyword to store either absolute error value or relative error value (depending on ERROR_MODE)

However, the logic is not transferred when converting to ResInsight (csv) and probably Webviz (yml) which means if user specify 10% relative error in OBS config file. ResInsight will see it as 10 in absolute error value.

At this stage, trigger the warning when user is using ERROR_MODE that is no ABS.

The logic will be implemented in another PR.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

Merging #628 (08f57ef) into main (f761f64) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

❗ Current head 08f57ef differs from pull request most recent head 4aa83c5. Consider uploading reports for the commit 4aa83c5 to get more accurate results

@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
- Coverage   84.00%   84.00%   -0.01%     
==========================================
  Files          52       52              
  Lines        7517     7521       +4     
==========================================
+ Hits         6315     6318       +3     
- Misses       1202     1203       +1     
Files Coverage Δ
src/subscript/fmuobs/fmuobs.py 82.02% <75.00%> (-0.17%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alifbe alifbe requested review from mferrera and rnyb October 27, 2023 13:10
Copy link
Collaborator

@rnyb rnyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alifbe alifbe merged commit 38cbb53 into equinor:main Oct 27, 2023
4 checks passed
@alifbe alifbe deleted the fmuobs_warn_on_erorr_mode branch October 27, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants