Skip to content

Replace ecl with resdata #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Replace ecl with resdata #631

merged 1 commit into from
Nov 15, 2023

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Nov 15, 2023

@DanSava DanSava force-pushed the replace_ecl branch 2 times, most recently from cbedcfd to b08409a Compare November 15, 2023 08:51
@codecov-commenter
Copy link

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (e4bad26) 84.72% compared to head (76fb347) 84.72%.

❗ Current head 76fb347 differs from pull request most recent head b08409a. Consider uploading reports for the commit b08409a to get more accurate results

Files Patch % Lines
src/subscript/sector2fluxnum/flux_obj.py 41.66% 7 Missing ⚠️
src/subscript/sector2fluxnum/sector2fluxnum.py 61.53% 5 Missing ⚠️
src/subscript/summaryplot/summaryplot.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #631   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files          52       52           
  Lines        7521     7521           
=======================================
  Hits         6372     6372           
  Misses       1149     1149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanSava DanSava self-assigned this Nov 15, 2023
@DanSava DanSava requested a review from berland November 15, 2023 10:36
Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DanSava DanSava merged commit e92301f into equinor:main Nov 15, 2023
@DanSava DanSava deleted the replace_ecl branch November 15, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants