Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use res2df instead of ecl2df #637

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Use res2df instead of ecl2df #637

merged 1 commit into from
Dec 14, 2023

Conversation

yngve-sk
Copy link

Hello from SCOUT, this is relating to the rename of ecl2df to res2df, I think this covers most of it but please double check it if something seems to be missing.

@yngve-sk yngve-sk force-pushed the rename-ecl2df-res2df branch from 1a184f9 to 77324df Compare December 12, 2023 07:46
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2142fc5) 86.14% compared to head (70e2c01) 85.38%.

❗ Current head 70e2c01 differs from pull request most recent head e83ae6f. Consider uploading reports for the commit e83ae6f to get more accurate results

Files Patch % Lines
src/subscript/check_swatinit/check_swatinit.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
- Coverage   86.14%   85.38%   -0.77%     
==========================================
  Files          49       49              
  Lines        7054     7054              
==========================================
- Hits         6077     6023      -54     
- Misses        977     1031      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yngve-sk yngve-sk force-pushed the rename-ecl2df-res2df branch from 77324df to 53d481b Compare December 12, 2023 08:00
@yngve-sk yngve-sk force-pushed the rename-ecl2df-res2df branch from 53d481b to e83ae6f Compare December 12, 2023 08:14
@mferrera mferrera merged commit 16b8d8c into main Dec 14, 2023
5 checks passed
@mferrera mferrera deleted the rename-ecl2df-res2df branch December 14, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants