Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to calculate mean, stdev for continuous 3D field parameter and facies probabilities for 3D facies parameter per zone #739

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

oddvarlia
Copy link
Collaborator

…s and estimated facies probabilities for discrete 3D parameter

@oddvarlia
Copy link
Collaborator Author

Purpose:
Calculate ensemble mean and standard deviation for 3D continuous parameters and estimates for facies probabilties for 3D facies parameters.
The estimates should be available per zone in the geomodel grid also for ensembles where the 3D geomodel grid vary from realization to realization as long as number of grid cells laterally (nx, ny) is fixed. To handle this, a fixed "gox" grid called ERTBOX grid is used.
The plan is also to be able to calculate this for field parameters used in APS in AHM workflows in ERT using ES-MDA:

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 88 lines in your changes missing coverage. Please review.

Project coverage is 85.43%. Comparing base (d07ca3f) to head (30103d7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/subscript/field_statistics/field_statistics.py 75.00% 88 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
- Coverage   85.97%   85.43%   -0.54%     
==========================================
  Files          51       52       +1     
  Lines        6837     7189     +352     
==========================================
+ Hits         5878     6142     +264     
- Misses        959     1047      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oddvarlia oddvarlia force-pushed the field_stats branch 3 times, most recently from 68ddb9e to d8e45fc Compare September 16, 2024 09:56
@oddvarlia oddvarlia requested a review from a team September 16, 2024 10:17
@oddvarlia
Copy link
Collaborator Author

I will add a specification using yaml as config file format instead of directly specifying a python dict.

@oddvarlia oddvarlia force-pushed the field_stats branch 6 times, most recently from 6028888 to 0635876 Compare September 17, 2024 12:34
@oddvarlia oddvarlia force-pushed the field_stats branch 6 times, most recently from 6a6cd89 to 9080d60 Compare September 24, 2024 16:26
…s and estimated facies probabilities for discrete 3D parameter
@oddvarlia oddvarlia force-pushed the field_stats branch 2 times, most recently from daa2305 to 1132829 Compare September 26, 2024 19:32
pyproject.toml Show resolved Hide resolved
@alifbe
Copy link
Collaborator

alifbe commented Sep 27, 2024

I think this PR looks great. I am still not sure if you need to have ert/model in your testdata folder.

Perhaps @rnyb or @mferrera can also have a look at this PR?

Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few improvements I think are possible here (print statements, commented out code, etc) but as a first pass to initialize a script I think we can take this as is for now.

@mferrera mferrera merged commit 9e052e7 into equinor:main Sep 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants