Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rporv workaround #743

Merged
merged 1 commit into from
Sep 27, 2024
Merged

add rporv workaround #743

merged 1 commit into from
Sep 27, 2024

Conversation

tralsos
Copy link
Collaborator

@tralsos tralsos commented Sep 26, 2024

When RFIP for each phase is missing in the UNRST file, the preferred resdata gravimetry method add_survey_RFIP is failing. A workaround is to use the add_survey_RPORV method instead, which calculates RFIP from RPORV and phase densitities. This is currently needed when using OPM FLOW as simulator, since it does not output RFIP to the UNRST file. Solves #740

Adding this workaround allows for implementation of the gravity modelling in Drogon.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.92%. Comparing base (4209590) to head (438a6f7).

Files with missing lines Patch % Lines
src/subscript/grav_subs_maps/grav_subs_maps.py 50.00% 2 Missing ⚠️
src/subscript/grav_subs_points/grav_subs_points.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
- Coverage   85.97%   85.92%   -0.05%     
==========================================
  Files          51       51              
  Lines        6837     6843       +6     
==========================================
+ Hits         5878     5880       +2     
- Misses        959      963       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tralsos tralsos requested a review from a team September 26, 2024 11:25
Copy link
Collaborator

@alifbe alifbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@tralsos tralsos merged commit 0ced59d into equinor:main Sep 27, 2024
6 checks passed
@tralsos tralsos deleted the no_rfip branch September 27, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants