Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed output file names from the generated rms script #746

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

oddvarlia
Copy link
Collaborator

Some parameters loaded into rms using the generated rms script from field_statistics.py lack the user defined label. This is fixed here.

@oddvarlia oddvarlia requested a review from alifbe October 1, 2024 09:31
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.03%. Comparing base (d73ac28) to head (23f6675).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #746   +/-   ##
=======================================
  Coverage   85.03%   85.03%           
=======================================
  Files          52       52           
  Lines        7229     7229           
=======================================
  Hits         6147     6147           
  Misses       1082     1082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alifbe alifbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@oddvarlia oddvarlia merged commit b5b3861 into equinor:main Oct 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants