Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use memoryconservative mode for WF CSV_MERGE #765

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

berland
Copy link
Collaborator

@berland berland commented Dec 11, 2024

When run as a workflow job/ert plugin this has been observed through logging to fail due to lack of memory.

When run as a workflow job, it is probable that there is one CSV for every realization that is to be loaded, thus the memory conservative option probably makes sense to have on by default.

Keeping the faster option as default for usages as a forward model step.

When run as a workflow job/ert plugin this has been observed through
logging to fail due to lack of memory.

When run as a workflow job, it is probable that there is one CSV for
every realization that is to be loaded, thus the memory conservative
option probably makes sense to have on by default.

Keeping the faster option as default for usages as a forward model step.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.15%. Comparing base (378bb74) to head (373ba36).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #765      +/-   ##
==========================================
- Coverage   85.17%   85.15%   -0.02%     
==========================================
  Files          52       52              
  Lines        7418     7418              
==========================================
- Hits         6318     6317       -1     
- Misses       1100     1101       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland berland self-assigned this Dec 13, 2024
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put my faith on you here.
Reasoning seems fair. 👍

@berland berland merged commit 42daa84 into main Dec 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants