Fixed initialization to make the generated script work more generally #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
=======================================
Coverage 85.15% 85.15%
=======================================
Files 52 52
Lines 7418 7418
=======================================
Hits 6317 6317
Misses 1101 1101 ☔ View full report in Codecov by Sentry. |
alifbe
approved these changes
Jan 13, 2025
Comment on lines
+1633
to
1635
| cont_prop_dict = None | ||
| if key in geogrid_fields_dict: | ||
| cont_prop_dict = geogrid_fields_dict[key] |
There was a problem hiding this comment.
Looks fine. One alternative solution is to use dictionary get method which reduces three lines of code into:
cont_prop_dict = geogrid_fields_dict.get(key, None)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field statistics script can generate a python script to be used as a job in RMS to load the mean and std dev and probability field parameters calculated by the field statistics script. Fixed missing initialization to make the script more flexible and avoid errors.