Skip to content

Commit

Permalink
Finish test for axes labels
Browse files Browse the repository at this point in the history
We had left one check commented out that was to be made into meaningful
code. As the test was passing (aside from the flakiness mentioned in
issue #297), this extra check was perhaps not really necessary, and were
not sure if it might help with the mentioned flakiness either.

Closes #306
  • Loading branch information
valentin-krasontovitsch committed Jul 6, 2022
1 parent 16df3f0 commit 35009d0
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions tests/views/test_response_correlation.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,7 @@ def test_axes_labels(mock_data, dash_duo):
)
selected_response_closer.click()

# wait for deselected option to reappear among available options
# response_selector_id = plugin.uuid("parameter-selector-multi-resp")
# dash_duo.wait_for_element(f"#{response_selector_id}
# wait for deselected option to reappear among available options
dash_duo.wait_for_contains_text(f"#{response_selector_id}", wanted_response)

# assert dash_duo.get_logs() == [], "browser console should contain no error"

0 comments on commit 35009d0

Please sign in to comment.