Update well log import and re-apply tests for MacOS #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
approved these changes
Apr 25, 2024
| @@ -292,7 +293,7 @@ def import_wlogs(wlogs: dict): | |||
| else: | |||
| raise ValueError(f"Invalid log type found in input: {typ}") | |||
|
|
|||
| if rec is None or isinstance(rec, dict): | |||
| if rec is None or isinstance(rec, Iterable): | |||
There was a problem hiding this comment.
Another option could be isinstance(rec, (dict, list)). Iterable will accomplish the same thing with a bit of a broader scope (also including set etc) so I think this is fine.
ErichSuter
force-pushed
the
re-apply-test-MacOS
branch
from
9bffe49
to
2f9f1a7
Compare
ErichSuter
force-pushed
the
re-apply-test-MacOS
branch
from
e5cd4b5
to
d9e77db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the rest of #908 (which was mostly addressed by #1188).
When re-applying the tests, an exception was raised as 'rec' can be dict or list.