Skip to content

CI: Add script for running tests from github worklow #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

slangeveld
Copy link
Contributor

@slangeveld slangeveld commented Jan 23, 2025

Resolves part of https://github.com/equinor/rms-sys/issues/267

Added a bash script that can be run from the github workflows to execute the xtgeo unit tests towards and RMS Python Enviroment. Note that the xtgeo-testdata files needed to run the tests are cached on the github actions runner, so pointing to the path XTGEO_TESTDATA_PATH with the cached data should be sufficient to run the tests.

The script copies the required test files, installs the test dependencies and and runs the pytests.

@slangeveld slangeveld requested a review from mferrera January 23, 2025 13:17
Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as other review, approving for convenience

@slangeveld slangeveld force-pushed the 267-add-testrmsenv-script branch from 46ca1d0 to 1fc630c Compare January 24, 2025 15:10
@slangeveld slangeveld force-pushed the 267-add-testrmsenv-script branch from 1fc630c to 9e73cde Compare January 24, 2025 15:22
@slangeveld
Copy link
Contributor Author

slangeveld commented Jan 28, 2025

A few changes where made based on the discussions in #1297

  • Roxar tests are included when running pytest
  • The pip install arguments --upgrade --force-reinstall have been removed from the command in the script as we decided to create a _rmsenv for each of the projects we are testing.
  • The xtgeo-testdata is now cached on the github runner, so cloning the xtgeo-testdata repo is no longer part of the test script.

@slangeveld slangeveld merged commit 7179fc7 into main Jan 28, 2025
35 checks passed
@slangeveld slangeveld deleted the 267-add-testrmsenv-script branch January 28, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants