Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding STL support and changing volume check to relative test #1266

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jhcollins
Copy link
Contributor

Mandatory Checklist

Please ensure that the following criteria are met:

  • Title of pull request describes the changes/features
  • Request at least 2 reviewers
  • If new files are being added, the files are no larger than 100kB. Post the file sizes.
  • Code coverage did not decrease. If this is a bug fix, a test should cover that bug fix. If a new feature is added, a test should be made to cover that feature.
  • New features have appropriate documentation strings (readable by sphinx)
  • Contributor has read and agreed with CONTRIBUTING.md and has added themselves to CONTRIBUTORS.md

As a general rule of thumb, try to follow PEP8 guidelines.

Description

Adding support for using setting up STL boundary conditions
changing lumped mass matrix/volume check to relative test.

Adding functions reloadBCList and assignFacetFlagsFromSTL for easier manipulation of ShapeSTL object.
making the lumped mass matrix/meshvolume check a relative test
@jhcollins jhcollins requested a review from cekees July 27, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant