Skip to content

feat: compile time checks and empty vs non empty #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 11, 2025

Conversation

dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented May 9, 2025

  • added: as subject
  • NOT in this pr: adding sugar macro and method to ease creation of vec+witness and type aliases

@coveralls
Copy link

coveralls commented May 9, 2025

Pull Request Test Coverage Report for Build 14945025399

Details

  • 36 of 62 (58.06%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-3.3%) to 47.244%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bounded_vec.rs 36 62 58.06%
Files with Coverage Reduction New Missed Lines %
src/bounded_vec.rs 2 47.24%
Totals Coverage Status
Change from base Build 12837324696: -3.3%
Covered Lines: 60
Relevant Lines: 127

💛 - Coveralls

@dzmitry-lahoda
Copy link
Contributor Author

@greenhat @sethdusek

please look when possible, hope sooner than later.

if you are ok - cool.

if not - will fork.

Copy link
Collaborator

@sethdusek sethdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I like the approach, it seems to be the best way to have compile-time checks until generic_const_exprs is stable. Please check my review comments

@dzmitry-lahoda dzmitry-lahoda requested a review from sethdusek May 10, 2025 11:45
@sethdusek sethdusek merged commit 39207d4 into ergoplatform:develop May 11, 2025
10 checks passed
@sethdusek
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants