CI: fix failing audit, bump rust version #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14908097067Details
💛 - Coveralls |
ignore paste issue for now, bump pyo3 to newer version even though we aren't affected by the vulnerabillity
kushti
approved these changes
May 9, 2025
| @@ -232,7 +232,7 @@ pub trait ReadSigmaVlqExt: io::Read + io::Seek { | |||
|
|
|||
| /// Read a vector of bits with the given size | |||
| fn get_bits(&mut self, size: usize) -> Result<Vec<bool>, VlqEncodingError> { | |||
| let byte_num = (size + 7) / 8; | |||
| let byte_num = size.div_ceil(8); | |||
There was a problem hiding this comment.
Yes, all the code changes are to address lints added in newer compiler versions. https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
| } else { | ||
| selected_boxes_value - target_balance | ||
| }; | ||
| let value_change_amt: u64 = selected_boxes_value.saturating_sub(target_balance); |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump rust version (needed by some dependencies), and fix issues reported by audit