Release Candidate v5.0.14 #943
Conversation
…lation of interpreter)
# Conflicts: # sdk/js/src/main/scala/org/ergoplatform/sdk/js/Isos.scala
# Conflicts: # interpreter/shared/src/main/scala/sigmastate/interpreter/Interpreter.scala # sc/shared/src/test/scala/org/ergoplatform/validation/RuleStatusSerializerSpec.scala # sdk/js/src/main/scala/org/ergoplatform/sdk/js/Isos.scala
Removing unused code #2
Removing unused code #3
…ntext.current.ergoTreeVersion")
More tests related to ErgoTree versioning
| @@ -3,8 +3,20 @@ package sigma | |||
| import debox.cfor | |||
| import scorex.util.encode.Base16 | |||
| import scorex.util.{ModifierId, bytesToId} | |||
| import sigma.data.RType | |||
|
|
|||
| object Extensions { | |||
| import sigma.ast.TypeCodes.LastConstantCode | ||
| import supertagged.TaggedType | ||
|
|
||
| /** Encoding of sigma proposition nodes. |
There was a problem hiding this comment.
"Opcodes of sigma proposition nodes" ?
| case BoxRType => SBox | ||
| case ContextRType => SContext | ||
| case SigmaDslBuilderRType => SGlobal | ||
| case HeaderRType => SHeader | ||
| case PreHeaderRType => SPreHeader | ||
| case SigmaPropRType => SSigmaProp | ||
| case SigmaBooleanRType => SSigmaProp | ||
| // TODO remove commented code below after full sync test |
There was a problem hiding this comment.
is full sync done? merging such code into master does not make sense
There was a problem hiding this comment.
rolled back to clean this PR from suspicious changes, better be done in a separate PR
|
|
||
| import java.nio.ByteBuffer | ||
|
|
||
| abstract class CoreSerializer[TFamily, T <: TFamily] extends Serializer[TFamily, T, CoreByteReader, CoreByteWriter] { |
There was a problem hiding this comment.
ScalaDoc missed, what does "Core" means ? While for XSeriazier, where X is come entity , a ScalaDoc is not needed, here we have something different than serializer of "Core"
There was a problem hiding this comment.
Added ScalaDocs for CoreXXX classes.
| * When f is obtained as `val f = getVar[Int => Int](id).get` then any application `f(x)` involves size estimation | ||
| * using underlying `costF(x)`. | ||
| * */ | ||
| //case class CFunc[A,B](context: sigmastate.interpreter.Context, tree: SValue) |
| @@ -174,14 +175,6 @@ object ReflectionData { | |||
| mkMethod(clazz, "updateOperations", Array[Class[_]](classOf[Byte])) { (obj, args) => | |||
| obj.asInstanceOf[AvlTree].updateOperations(args(0).asInstanceOf[Byte]) | |||
| }, | |||
| mkMethod(clazz, "getMany", Array[Class[_]](classOf[Coll[_]], classOf[Coll[_]])) { (obj, args) => | |||
There was a problem hiding this comment.
why removed?
Where methods from this file are called btw ? ScalaDoc for ReflectionData is obscure
There was a problem hiding this comment.
they removed because those methods of AvlTree never called via reflection. Interpreter calls them via xxx_eval methods. Search for an example mkMethod(clazz, "getMany_eval",
In this release:
coremodule (part 1) #913isUsingBlockchainContextto ErgoTree #929Contributors: @aslesarenko, @kushti, @megatron00999, @ross-weir