Skip to content

Commit

Permalink
not sure why the oracle driver customizes this but their custom one w…
Browse files Browse the repository at this point in the history
…orked in a dev metabase but not a prod one for me
  • Loading branch information
ericcj committed Nov 9, 2022
1 parent e186c30 commit ca666a3
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/metabase/driver/netsuite.clj
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@
(dissoc :host :port :account-id :role-id)
(finish-fn host port account-id role-id))))

; not sure why the oracle driver customizes this but their custom one worked in a dev metabase but not a prod one for me
(defmethod driver/can-connect? :netsuite
[driver details]
((get-method driver/can-connect? :sql-jdbc) driver details))

; TIMESTAMP columns (e.g. item.createddate) were causing "Receiver class com.netsuite.jdbc.oabase.oacb does not define or inherit an implementation of the resolved method 'abstract java.lang.Object getObject(int, java.lang.Class)' of interface java.sql.ResultSet"
; maybe this is a similar concern to how the oracle driver handles TIMESTAMPTZ?
(defmethod sql-jdbc.execute/read-column-thunk [:netsuite Types/TIMESTAMP]
Expand Down

0 comments on commit ca666a3

Please sign in to comment.