Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PASS/FAIL is also valid TestOutcome #138

Merged
merged 2 commits into from
Jul 31, 2024
Merged

PASS/FAIL is also valid TestOutcome #138

merged 2 commits into from
Jul 31, 2024

Conversation

sagudev
Copy link
Collaborator

@sagudev sagudev commented Jul 31, 2024

Fixes #79

sagudev and others added 2 commits July 31, 2024 13:53
@sagudev
PASS/FAIL is also valid TestOutcome
6a1b79d 
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
@ErichDonGubler
fixup! PASS/FAIL is also valid TestOutcome
dedb207
ErichDonGubler
ErichDonGubler approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@ErichDonGubler ErichDonGubler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After I fixed up UpdateBacklog's PromotePermaPassing preset to include PASS as a Case::PermaPass, this LGTM. Merging! 🙂

@ErichDonGubler ErichDonGubler merged commit 52a0fa4 into erichdongubler-mozilla:main Jul 31, 2024
24 of 25 checks passed
@ErichDonGubler ErichDonGubler self-assigned this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErichDonGubler ErichDonGubler ErichDonGubler approved these changes

Assignees

@ErichDonGubler ErichDonGubler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors on parsing valid metadata
2 participants
@sagudev @ErichDonGubler