Skip to content

Fix goreleaser step ordering#47

Merged
erichs merged 2 commits intomainfrom
fix-release-2
Dec 17, 2025
Merged

Fix goreleaser step ordering#47
erichs merged 2 commits intomainfrom
fix-release-2

Conversation

@erichs
Copy link
Owner

@erichs erichs commented Dec 17, 2025

Avoid dirtying the git state by moving sbom generation after goreleaser builds.

Copilot AI review requested due to automatic review settings December 17, 2025 18:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the order of operations in the release workflow to prevent goreleaser from dirtying the git state. The issue occurred because goreleaser runs go mod tidy as a before hook, which could modify files after the SBOM was generated. By moving SBOM generation to after goreleaser completes, the workflow ensures all git state modifications happen before the SBOM is created.

Key changes:

  • Moved SBOM generation from before goreleaser to after goreleaser execution
  • Combined separate "Generate" and "Upload" steps into a single "Generate and Upload Source SBOM" step

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.14%. Comparing base (e5739f6) to head (d75257d).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   87.14%   87.14%           
=======================================
  Files          46       46           
  Lines        2474     2474           
=======================================
  Hits         2156     2156           
  Misses        218      218           
  Partials      100      100           
Flag Coverage Δ
unittests 87.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@erichs erichs merged commit faf2a00 into main Dec 17, 2025
5 checks passed
@erichs erichs deleted the fix-release-2 branch December 17, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments